FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.2

Threshold is Low

Effort is Max

Summary

Classes Bugs Errors Missing Classes
404 128 0 0

Files

Class Bugs
com.gridsystems.innergrid.kernel.ixos.IxosAuthenticator 3
com.gridsystems.innergrid.kernel.ixos.IxosPlugin 3
com.gridsystems.innergrid.kernel.ixos.filesystem.ApiFileSystemImpl 1
com.gridsystems.innergrid.kernel.ixos.filesystem.FileAccessorManager$Cleaner 1
com.gridsystems.innergrid.kernel.ixos.filesystem.FileAccessor 1
com.gridsystems.innergrid.kernel.ixos.filesystem.FileAccessorManager 1
com.gridsystems.innergrid.kernel.ixos.filesystem.FileAcl 4
com.gridsystems.innergrid.kernel.ixos.filesystem.FileHandler 2
com.gridsystems.innergrid.kernel.ixos.filesystem.FileManager 5
com.gridsystems.innergrid.kernel.ixos.filesystem.FileManager$ReadDirInfoPagedRequest 1
com.gridsystems.innergrid.kernel.ixos.filesystem.FileSystemEvent 1
com.gridsystems.innergrid.kernel.ixos.filesystem.IxosSecurityManager 2
com.gridsystems.innergrid.kernel.ixos.filesystem.KernelSecurityException 1
com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager 10
com.gridsystems.innergrid.kernel.ixos.filesystem.ROFileAccessor 3
com.gridsystems.innergrid.kernel.ixos.filesystem.RWFileAccessor 5
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile 10
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile$PublicFilenameFilter 1
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile$RmTreeNative 1
com.gridsystems.innergrid.kernel.ixos.filesystem.WOFileAccessor 2
com.gridsystems.innergrid.kernel.ixos.filesystem.ZipManager 2
com.gridsystems.innergrid.kernel.ixos.usersystem.Acl 1
com.gridsystems.innergrid.kernel.ixos.usersystem.AclEvent 1
com.gridsystems.innergrid.kernel.ixos.usersystem.AclInfo 6
com.gridsystems.innergrid.kernel.ixos.usersystem.AclList 2
com.gridsystems.innergrid.kernel.ixos.usersystem.AclListDAO 1
com.gridsystems.innergrid.kernel.ixos.usersystem.AclListDAO$1 1
com.gridsystems.innergrid.kernel.ixos.usersystem.AclListDAO$2 1
com.gridsystems.innergrid.kernel.ixos.usersystem.AclRole 1
com.gridsystems.innergrid.kernel.ixos.usersystem.AclUser 3
com.gridsystems.innergrid.kernel.ixos.usersystem.ApiAclImpl 2
com.gridsystems.innergrid.kernel.ixos.usersystem.ApiUserSystemImpl 8
com.gridsystems.innergrid.kernel.ixos.usersystem.PermissionsCleanerThread 2
com.gridsystems.innergrid.kernel.ixos.usersystem.RoleData 4
com.gridsystems.innergrid.kernel.ixos.usersystem.UserData 5
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRights 2
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList 24
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList$2 1
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList$3 1
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleListDAO 2

com.gridsystems.innergrid.kernel.ixos.IxosAuthenticator

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.IxosAuthenticator.ensureRoleExists(String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 461
Method com.gridsystems.innergrid.kernel.ixos.IxosAuthenticator.purgeList(String[], String[]) uses Collection.toArray() with zero-length array argument PERFORMANCE ITA_INEFFICIENT_TO_ARRAY 427
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.IxosAuthenticator.authorize(String, String) STYLE REC_CATCH_EXCEPTION 187

com.gridsystems.innergrid.kernel.ixos.IxosPlugin

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.IxosPlugin.unzip(InputStream, File) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 465
com.gridsystems.innergrid.kernel.ixos.IxosPlugin.createNewRepository(File) ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 411
com.gridsystems.innergrid.kernel.ixos.IxosPlugin.unzip(InputStream, File) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 453

com.gridsystems.innergrid.kernel.ixos.filesystem.ApiFileSystemImpl

Bug Category Details Line
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.ApiFileSystemImpl.normalize(String) STYLE REC_CATCH_EXCEPTION 347

com.gridsystems.innergrid.kernel.ixos.filesystem.FileAccessorManager$Cleaner

Bug Category Details Line
Inconsistent synchronization of com.gridsystems.innergrid.kernel.ixos.filesystem.FileAccessor.lastAccess; locked 66% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 221

com.gridsystems.innergrid.kernel.ixos.filesystem.FileAccessor

Bug Category Details Line
Switch statement found in com.gridsystems.innergrid.kernel.ixos.filesystem.FileAccessor.createInstance(RepositoryFile, int, boolean) where one case falls through to the next case STYLE SF_SWITCH_FALLTHROUGH 329-331

com.gridsystems.innergrid.kernel.ixos.filesystem.FileAccessorManager

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.filesystem.FileAccessorManager.pool isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 78

com.gridsystems.innergrid.kernel.ixos.filesystem.FileAcl

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.filesystem.FileAcl.getRolePermissions() may expose internal representation by returning FileAcl.rolePerms MALICIOUS_CODE EI_EXPOSE_REP 173
com.gridsystems.innergrid.kernel.ixos.filesystem.FileAcl.getUserPermissions() may expose internal representation by returning FileAcl.userPerms MALICIOUS_CODE EI_EXPOSE_REP 154
com.gridsystems.innergrid.kernel.ixos.filesystem.FileAcl.setRolePermissions(FilePermissions[]) may expose internal representation by storing an externally mutable object into FileAcl.rolePerms MALICIOUS_CODE EI_EXPOSE_REP2 183
com.gridsystems.innergrid.kernel.ixos.filesystem.FileAcl.setUserPermissions(FilePermissions[]) may expose internal representation by storing an externally mutable object into FileAcl.userPerms MALICIOUS_CODE EI_EXPOSE_REP2 164

com.gridsystems.innergrid.kernel.ixos.filesystem.FileHandler

Bug Category Details Line
Comparison of String objects using == or != in com.gridsystems.innergrid.kernel.ixos.filesystem.FileHandler.equals(Object) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 106
FileHandler.ref not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

com.gridsystems.innergrid.kernel.ixos.filesystem.FileManager

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.filesystem.FileManager.readAsStream(DataHandler, RepositoryFile, boolean) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 678
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.FileManager.copy(String, String, boolean) STYLE REC_CATCH_EXCEPTION 264
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.FileManager.rename(String, String) STYLE REC_CATCH_EXCEPTION 798
com.gridsystems.innergrid.kernel.ixos.filesystem.FileManager.rmSecFiles(File) ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 854
com.gridsystems.innergrid.kernel.ixos.filesystem.FileManager.writeFile(String, DataHandler, boolean) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 510

com.gridsystems.innergrid.kernel.ixos.filesystem.FileManager$ReadDirInfoPagedRequest

Bug Category Details Line
Should com.gridsystems.innergrid.kernel.ixos.filesystem.FileManager$ReadDirInfoPagedRequest be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 869-930

com.gridsystems.innergrid.kernel.ixos.filesystem.FileSystemEvent

Bug Category Details Line
Method new com.gridsystems.innergrid.kernel.ixos.filesystem.FileSystemEvent(int, RepositoryFile, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 96

com.gridsystems.innergrid.kernel.ixos.filesystem.IxosSecurityManager

Bug Category Details Line
Redundant nullcheck of fsec, which is known to be non-null in com.gridsystems.innergrid.kernel.ixos.filesystem.IxosSecurityManager.getSecurityProperties(File, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 605
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.IxosSecurityManager.findSecurityFile(File) STYLE REC_CATCH_EXCEPTION 653

com.gridsystems.innergrid.kernel.ixos.filesystem.KernelSecurityException

Bug Category Details Line
new com.gridsystems.innergrid.kernel.ixos.filesystem.KernelSecurityException(String, Object[], Throwable) may expose internal representation by storing an externally mutable object into KernelSecurityException.params MALICIOUS_CODE EI_EXPOSE_REP2 60

com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager

Bug Category Details Line
Method com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager.cleanNulls(FilePermissions[]) uses Collection.toArray() with zero-length array argument PERFORMANCE ITA_INEFFICIENT_TO_ARRAY 1053
Naked notify in com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager.unlock(File) MT_CORRECTNESS NN_NAKED_NOTIFY 472
Should com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager.cleanNulls(FilePermissions[]) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 1041
Should com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager.mergeFilePermissions(FileAcl) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 1014
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager.chmodAdd(File, FilePermissions[], boolean, boolean) STYLE REC_CATCH_EXCEPTION 677
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager.chmodRemove(File, FilePermissions[], boolean, boolean) STYLE REC_CATCH_EXCEPTION 802
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager.chmod(File, FilePermissions[]) STYLE REC_CATCH_EXCEPTION 196
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager.getPermissions(String, File) STYLE REC_CATCH_EXCEPTION 268
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager.quickChmod(File, FilePermissions[]) STYLE REC_CATCH_EXCEPTION 237
Switch statement found in com.gridsystems.innergrid.kernel.ixos.filesystem.PermissionsManager.unlock(File) where one case falls through to the next case STYLE SF_SWITCH_FALLTHROUGH 456-459

com.gridsystems.innergrid.kernel.ixos.filesystem.ROFileAccessor

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.filesystem.ROFileAccessor.close() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 95
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.ROFileAccessor.close() STYLE REC_CATCH_EXCEPTION 95
com.gridsystems.innergrid.kernel.ixos.filesystem.ROFileAccessor.open() ignores result of java.io.InputStream.skip(long) BAD_PRACTICE SR_NOT_CHECKED 79

com.gridsystems.innergrid.kernel.ixos.filesystem.RWFileAccessor

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.filesystem.RWFileAccessor.close() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 102
com.gridsystems.innergrid.kernel.ixos.filesystem.RWFileAccessor.updateLastAccess() might ignore java.io.IOException BAD_PRACTICE DE_MIGHT_IGNORE 73
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.RWFileAccessor.close() STYLE REC_CATCH_EXCEPTION 102
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.RWFileAccessor.open() STYLE REC_CATCH_EXCEPTION 89
RWFileAccessor.raf not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile.listACL() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 800
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile.listInfo() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 779
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile.listMetaData() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 822
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile.mkdir() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 350
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 941
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 968
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile.remove() ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 674
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile.rmTreeFast() ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 564
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile.rmdir() ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 442
com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile.touch(boolean) ignores exceptional return value of java.io.File.setLastModified(long) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 401

com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile$PublicFilenameFilter

Bug Category Details Line
Should com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile$PublicFilenameFilter be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 996-1002

com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile$RmTreeNative

Bug Category Details Line
Should com.gridsystems.innergrid.kernel.ixos.filesystem.RepositoryFile$RmTreeNative be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 589-609

com.gridsystems.innergrid.kernel.ixos.filesystem.WOFileAccessor

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.filesystem.WOFileAccessor.close() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 92
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.WOFileAccessor.close() STYLE REC_CATCH_EXCEPTION 92

com.gridsystems.innergrid.kernel.ixos.filesystem.ZipManager

Bug Category Details Line
Empty zip file entry created in com.gridsystems.innergrid.kernel.ixos.filesystem.ZipManager.zipFile(ZipOutputStream, String, File) BAD_PRACTICE AM_CREATES_EMPTY_ZIP_FILE_ENTRY 187
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.filesystem.ZipManager.zip(String[]) STYLE REC_CATCH_EXCEPTION 121

com.gridsystems.innergrid.kernel.ixos.usersystem.Acl

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.usersystem.Acl.dao isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 46

com.gridsystems.innergrid.kernel.ixos.usersystem.AclEvent

Bug Category Details Line
Method com.gridsystems.innergrid.kernel.ixos.usersystem.AclEvent.notify(AclListener) uses the same code for two switch clauses STYLE DB_DUPLICATE_SWITCH_CLAUSES 234-235

com.gridsystems.innergrid.kernel.ixos.usersystem.AclInfo

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.usersystem.AclInfo.getPermissions() may expose internal representation by returning AclInfo.permissions MALICIOUS_CODE EI_EXPOSE_REP 126
com.gridsystems.innergrid.kernel.ixos.usersystem.AclInfo.getRoleOwners() may expose internal representation by returning AclInfo.roleOwners MALICIOUS_CODE EI_EXPOSE_REP 163
com.gridsystems.innergrid.kernel.ixos.usersystem.AclInfo.getUserOwners() may expose internal representation by returning AclInfo.userOwners MALICIOUS_CODE EI_EXPOSE_REP 144
com.gridsystems.innergrid.kernel.ixos.usersystem.AclInfo.setPermissions(String[]) may expose internal representation by storing an externally mutable object into AclInfo.permissions MALICIOUS_CODE EI_EXPOSE_REP2 135
com.gridsystems.innergrid.kernel.ixos.usersystem.AclInfo.setRoleOwners(String[]) may expose internal representation by storing an externally mutable object into AclInfo.roleOwners MALICIOUS_CODE EI_EXPOSE_REP2 173
com.gridsystems.innergrid.kernel.ixos.usersystem.AclInfo.setUserOwners(String[]) may expose internal representation by storing an externally mutable object into AclInfo.userOwners MALICIOUS_CODE EI_EXPOSE_REP2 154

com.gridsystems.innergrid.kernel.ixos.usersystem.AclList

Bug Category Details Line
Method com.gridsystems.innergrid.kernel.ixos.usersystem.AclList.getAllAclDomains() uses Collection.toArray() with zero-length array argument PERFORMANCE ITA_INEFFICIENT_TO_ARRAY 79
com.gridsystems.innergrid.kernel.ixos.usersystem.AclList.dao isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 86

com.gridsystems.innergrid.kernel.ixos.usersystem.AclListDAO

Bug Category Details Line
Method com.gridsystems.innergrid.kernel.ixos.usersystem.AclListDAO.load(String[]) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 136

com.gridsystems.innergrid.kernel.ixos.usersystem.AclListDAO$1

Bug Category Details Line
The class com.gridsystems.innergrid.kernel.ixos.usersystem.AclListDAO$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 73-75

com.gridsystems.innergrid.kernel.ixos.usersystem.AclListDAO$2

Bug Category Details Line
The class com.gridsystems.innergrid.kernel.ixos.usersystem.AclListDAO$2 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 82-85

com.gridsystems.innergrid.kernel.ixos.usersystem.AclRole

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 182

com.gridsystems.innergrid.kernel.ixos.usersystem.AclUser

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 60
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 90
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 147

com.gridsystems.innergrid.kernel.ixos.usersystem.ApiAclImpl

Bug Category Details Line
Incorrect lazy initialization of static field com.gridsystems.innergrid.kernel.ixos.usersystem.ApiAclImpl.instance in com.gridsystems.innergrid.kernel.ixos.usersystem.ApiAclImpl.getInstance() MT_CORRECTNESS LI_LAZY_INIT_STATIC 66-67
Redundant nullcheck of acl, which is known to be non-null in com.gridsystems.innergrid.kernel.ixos.usersystem.ApiAclImpl.getCheckedAcl(String, String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 595

com.gridsystems.innergrid.kernel.ixos.usersystem.ApiUserSystemImpl

Bug Category Details Line
Should com.gridsystems.innergrid.kernel.ixos.usersystem.ApiUserSystemImpl.getAllRoles() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 253
Should com.gridsystems.innergrid.kernel.ixos.usersystem.ApiUserSystemImpl.getAllUsers() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 163
Should com.gridsystems.innergrid.kernel.ixos.usersystem.ApiUserSystemImpl.getNonDeletableRoles() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 269
Redundant nullcheck of roles, which is known to be non-null in com.gridsystems.innergrid.kernel.ixos.usersystem.ApiUserSystemImpl.getAllRoles() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 252
Redundant nullcheck of userData, which is known to be non-null in com.gridsystems.innergrid.kernel.ixos.usersystem.ApiUserSystemImpl.getAllUsers() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 162
Redundant nullcheck of roles, which is known to be non-null in com.gridsystems.innergrid.kernel.ixos.usersystem.ApiUserSystemImpl.getNonDeletableRoles() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 268
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.usersystem.ApiUserSystemImpl.getRolesOfUser(String) STYLE REC_CATCH_EXCEPTION 199
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.usersystem.ApiUserSystemImpl.getUsersOfRole(String) STYLE REC_CATCH_EXCEPTION 300

com.gridsystems.innergrid.kernel.ixos.usersystem.PermissionsCleanerThread

Bug Category Details Line
Incorrect lazy initialization and update of static field com.gridsystems.innergrid.kernel.ixos.usersystem.PermissionsCleanerThread.instance in com.gridsystems.innergrid.kernel.ixos.usersystem.PermissionsCleanerThread.startCleaner(long) MT_CORRECTNESS LI_LAZY_INIT_UPDATE_STATIC 422-431
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.usersystem.PermissionsCleanerThread.cleanFilePermissions(File) STYLE REC_CATCH_EXCEPTION 301

com.gridsystems.innergrid.kernel.ixos.usersystem.RoleData

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.usersystem.RoleData.returnUsers() may expose internal representation by returning RoleData.users MALICIOUS_CODE EI_EXPOSE_REP 137
com.gridsystems.innergrid.kernel.ixos.usersystem.RoleData.putUsers(Hashtable) may expose internal representation by storing an externally mutable object into RoleData.users MALICIOUS_CODE EI_EXPOSE_REP2 146
com.gridsystems.innergrid.kernel.ixos.usersystem.RoleData defines compareTo(Object) and uses Object.equals() BAD_PRACTICE EQ_COMPARETO_USE_OBJECT_EQUALS 160-161
RoleData.roleName not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

com.gridsystems.innergrid.kernel.ixos.usersystem.UserData

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 112
com.gridsystems.innergrid.kernel.ixos.usersystem.UserData.returnRoles() may expose internal representation by returning UserData.roles MALICIOUS_CODE EI_EXPOSE_REP 251
com.gridsystems.innergrid.kernel.ixos.usersystem.UserData.putRoles(Hashtable) may expose internal representation by storing an externally mutable object into UserData.roles MALICIOUS_CODE EI_EXPOSE_REP2 259
com.gridsystems.innergrid.kernel.ixos.usersystem.UserData defines compareTo(Object) and uses Object.equals() BAD_PRACTICE EQ_COMPARETO_USE_OBJECT_EQUALS 291-292
UserData.userName not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

com.gridsystems.innergrid.kernel.ixos.usersystem.UserRights

Bug Category Details Line
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRights.getGrantingRoles() may expose internal representation by returning UserRights.grantingRoles MALICIOUS_CODE EI_EXPOSE_REP 125
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRights.setGrantingRoles(String[]) may expose internal representation by storing an externally mutable object into UserRights.grantingRoles MALICIOUS_CODE EI_EXPOSE_REP2 114

com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList

Bug Category Details Line
Class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList is final but declares protected field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.ROLERELATIVEPATH STYLE CI_CONFUSED_INHERITANCE Not available
Class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList is final but declares protected field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.USERRELATIVEPATH STYLE CI_CONFUSED_INHERITANCE Not available
Class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList is final but declares protected field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.administratorRole STYLE CI_CONFUSED_INHERITANCE Not available
Class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList is final but declares protected field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.instance STYLE CI_CONFUSED_INHERITANCE Not available
Class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList is final but declares protected field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.lockstore STYLE CI_CONFUSED_INHERITANCE Not available
Class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList is final but declares protected field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.log STYLE CI_CONFUSED_INHERITANCE Not available
Class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList is final but declares protected field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.roles STYLE CI_CONFUSED_INHERITANCE Not available
Class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList is final but declares protected field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.users STYLE CI_CONFUSED_INHERITANCE Not available
Class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList is final but declares protected field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.usersDefaultRole STYLE CI_CONFUSED_INHERITANCE Not available
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 591
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.administratorRole should be package protected MALICIOUS_CODE MS_PKGPROTECT 79
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.dao isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 58
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.instance isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 63
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.log isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 53
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.usersDefaultRole isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 84
com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.lockstore isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 99
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.addUserToRole(String, String) STYLE REC_CATCH_EXCEPTION 192
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.deleteRole(String) STYLE REC_CATCH_EXCEPTION 328
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.deleteUserFromRole(String, String) STYLE REC_CATCH_EXCEPTION 870
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.setRole(Role) STYLE REC_CATCH_EXCEPTION 411
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.setUser(User) STYLE REC_CATCH_EXCEPTION 359
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.setUserPassword(String, String) STYLE REC_CATCH_EXCEPTION 384
Write to static field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.administratorRole from instance method com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.reset(String, String) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 688
Write to static field com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.administratorRole from instance method com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList.setAdministratorRole(RoleData) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 748

com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList$2

Bug Category Details Line
The class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList$2 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 762-765

com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList$3

Bug Category Details Line
The class com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleList$3 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 776-779

com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleListDAO

Bug Category Details Line
Redundant nullcheck of userName, which is known to be non-null in com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleListDAO.loadUsers(File) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 197
Nullcheck of pass at line 298 of value previously dereferenced in com.gridsystems.innergrid.kernel.ixos.usersystem.UserRoleListDAO.store(Properties, UserData) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 298