FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.2

Threshold is Low

Effort is Max

Summary

Classes Bugs Errors Missing Classes
249 46 0 0

Files

Class Bugs
com.gridsystems.gridexception.GridException 3
com.gridsystems.utils.ClassDiscovery 1
java.util.Hashtable 1
com.gridsystems.utils.FileProperties 2
com.gridsystems.utils.FileUtils 12
com.gridsystems.utils.JNIUtils 4
com.gridsystems.utils.KeyStoreUtils 1
com.gridsystems.utils.NativeShell 4
com.gridsystems.utils.NetUtils 3
com.gridsystems.utils.SecureFileProperties 1
com.gridsystems.utils.SortedFileProperties 1
com.gridsystems.utils.SystemUtils 10
com.gridsystems.utils.SystemUtils$SystemStream 1
com.gridsystems.utils.Version 1
com.gridsystems.utils.text.EOLUtils 1

com.gridsystems.gridexception.GridException

Bug Category Details Line
com.gridsystems.gridexception.GridException.getParams() may expose internal representation by returning GridException.params MALICIOUS_CODE EI_EXPOSE_REP 77
new com.gridsystems.gridexception.GridException(String, String[]) may expose internal representation by storing an externally mutable object into GridException.params MALICIOUS_CODE EI_EXPOSE_REP2 54
Unwritten field: com.gridsystems.gridexception.GridException.message CORRECTNESS UWF_UNWRITTEN_FIELD 70

com.gridsystems.utils.ClassDiscovery

Bug Category Details Line
com.gridsystems.utils.ClassDiscovery.findInJars(String, String, String, Class) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 61

java.util.Hashtable

Bug Category Details Line
com.gridsystems.utils.FileProperties doesn't override java.util.Hashtable.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 736-765

com.gridsystems.utils.FileProperties

Bug Category Details Line
Inconsistent synchronization of com.gridsystems.utils.FileProperties.header; locked 75% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 125
com.gridsystems.utils.FileProperties.synchronize isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 60

com.gridsystems.utils.FileUtils

Bug Category Details Line
com.gridsystems.utils.FileUtils.close(Object) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 82
Invocation of toString on cmdline in com.gridsystems.utils.FileUtils.chmod(String, File, boolean) CORRECTNESS DMI_INVOKING_TOSTRING_ON_ARRAY 966
Comparison of String objects using == or != in com.gridsystems.utils.FileUtils.copyNative(File, File) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 754
Exception is caught when Exception is not thrown in com.gridsystems.utils.FileUtils.close(Object) STYLE REC_CATCH_EXCEPTION 82
Exception is caught when Exception is not thrown in com.gridsystems.utils.FileUtils.copy(File, File) STYLE REC_CATCH_EXCEPTION 854
Exception is caught when Exception is not thrown in com.gridsystems.utils.FileUtils.readText(File) STYLE REC_CATCH_EXCEPTION 181
com.gridsystems.utils.FileUtils.copyDir(File, File) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 802
com.gridsystems.utils.FileUtils.copyDirNative(File, File) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 701
com.gridsystems.utils.FileUtils.copyNative(File, File) ignores exceptional return value of java.io.File.createNewFile() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 759
com.gridsystems.utils.FileUtils.copyNative(File, File) ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 782
com.gridsystems.utils.FileUtils.unzip(File, File, boolean, FileUtils$UnzipListener, FileFilter) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 460
com.gridsystems.utils.FileUtils.unzip(InputStream, File) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 557

com.gridsystems.utils.JNIUtils

Bug Category Details Line
com.gridsystems.utils.JNIUtils.getDllTempFile(String, int, String, File) invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 188
Null pointer dereference of fos in com.gridsystems.utils.JNIUtils.copyLibrary(File, InputStream, String) on exception path CORRECTNESS NP_ALWAYS_NULL_EXCEPTION 241
Should com.gridsystems.utils.JNIUtils.getNativePrefixPostfix(String) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 61
com.gridsystems.utils.JNIUtils.extractDynamicLibrary(String, String) ignores exceptional return value of java.io.File.mkdir() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 120

com.gridsystems.utils.KeyStoreUtils

Bug Category Details Line
Load of known null value in com.gridsystems.utils.KeyStoreUtils.createEmptyKeyStore(char[]) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 165

com.gridsystems.utils.NativeShell

Bug Category Details Line
Possible null pointer dereference of out in com.gridsystems.utils.NativeShell.doExec(String, String, Object[]) CORRECTNESS NP_NULL_ON_SOME_PATH 393
Should com.gridsystems.utils.NativeShell.doShell(String, String, Object[]) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 229
com.gridsystems.utils.NativeShell.setStdErr(File) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 320
com.gridsystems.utils.NativeShell.setStdOut(File) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 281

com.gridsystems.utils.NetUtils

Bug Category Details Line
Redundant nullcheck of ip which is known to be null in com.gridsystems.utils.NetUtils.getMachineIP() STYLE RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE 170
Redundant nullcheck of ip which is known to be null in com.gridsystems.utils.NetUtils.getMachineIP() STYLE RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE 175
Exception is caught when Exception is not thrown in com.gridsystems.utils.NetUtils.checkServerSocketFreePort(int) STYLE REC_CATCH_EXCEPTION 101

com.gridsystems.utils.SecureFileProperties

Bug Category Details Line
com.gridsystems.utils.SecureFileProperties.commit() may fail to close stream on exception BAD_PRACTICE OS_OPEN_STREAM_EXCEPTION_PATH 76

com.gridsystems.utils.SortedFileProperties

Bug Category Details Line
com.gridsystems.utils.SortedFileProperties.commit() may fail to close stream on exception BAD_PRACTICE OS_OPEN_STREAM_EXCEPTION_PATH 72

com.gridsystems.utils.SystemUtils

Bug Category Details Line
com.gridsystems.utils.SystemUtils.register(String, String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 212
Invocation of toString on command in com.gridsystems.utils.SystemUtils.execAndSaveOutput(String[], String[], File, OutputStream, boolean) CORRECTNESS DMI_INVOKING_TOSTRING_ON_ARRAY 464
Invocation of toString on command in com.gridsystems.utils.SystemUtils.execPiped(String[], String[], File, boolean) CORRECTNESS DMI_INVOKING_TOSTRING_ON_ARRAY 514
Method com.gridsystems.utils.SystemUtils.execAndSaveOutput(String[], String[], File, OutputStream, boolean) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 462
Method com.gridsystems.utils.SystemUtils.execPiped(String[], String[], File, boolean) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 512
Incorrect lazy initialization of static field com.gridsystems.utils.SystemUtils.internalEntry in com.gridsystems.utils.SystemUtils.getInternalEntry() MT_CORRECTNESS LI_LAZY_INIT_STATIC 320-322
Exception is caught when Exception is not thrown in com.gridsystems.utils.SystemUtils.<static initializer>() STYLE REC_CATCH_EXCEPTION 190
Exception is caught when Exception is not thrown in com.gridsystems.utils.SystemUtils.execAndSaveOutput(String[], String[], File, OutputStream, boolean) STYLE REC_CATCH_EXCEPTION 463
Exception is caught when Exception is not thrown in com.gridsystems.utils.SystemUtils.execPiped(String[], String[], File, boolean) STYLE REC_CATCH_EXCEPTION 513
Exception is caught when Exception is not thrown in com.gridsystems.utils.SystemUtils.register(String, String) STYLE REC_CATCH_EXCEPTION 212

com.gridsystems.utils.SystemUtils$SystemStream

Bug Category Details Line
Class com.gridsystems.utils.SystemUtils$SystemStream implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 590-633

com.gridsystems.utils.Version

Bug Category Details Line
Method new com.gridsystems.utils.Version(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 64

com.gridsystems.utils.text.EOLUtils

Bug Category Details Line
com.gridsystems.utils.text.EOLUtils.SCHEMENAMES should be package protected MALICIOUS_CODE MS_PKGPROTECT 54