FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.2

Threshold is Low

Effort is Max

Summary

Classes Bugs Errors Missing Classes
639 82 0 0

Files

Class Bugs
com.gridsystems.innergrid.kernel.Kernel 8
com.gridsystems.innergrid.kernel.Messages 1
com.gridsystems.innergrid.kernel.crypto.CryptoService 9
com.gridsystems.innergrid.kernel.examples.dummy.DummyAAService 2
com.gridsystems.innergrid.kernel.examples.dummy.DummyApiImpl 1
com.gridsystems.innergrid.kernel.plugin.AbstractPluginFactory 1
com.gridsystems.innergrid.kernel.plugin.PluginAdapter 3
com.gridsystems.innergrid.kernel.plugin.PluginManager 3
com.gridsystems.innergrid.kernel.plugin.PluginVersion 1
com.gridsystems.innergrid.kernel.plugin.StaticPluginFactory 1
com.gridsystems.innergrid.kernel.server.ApiConfiguration 3
com.gridsystems.innergrid.kernel.server.KernelConfig 1
com.gridsystems.innergrid.kernel.server.OutOfMemoryFilter 2
com.gridsystems.innergrid.kernel.server.RequestFilterEvent 2
com.gridsystems.innergrid.kernel.server.WSSWrapperHandler 6
com.gridsystems.innergrid.kernel.services.ApiKernelManagerImpl 4
com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl 1
com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl$StopTask 5
com.gridsystems.innergrid.kernel.services.AttachmentCleaner 1
com.gridsystems.innergrid.kernel.services.Connector 5
com.gridsystems.innergrid.kernel.services.LicenseZipManager 3
com.gridsystems.innergrid.kernel.services.PluginInfo 2
com.gridsystems.innergrid.kernel.services.ServerInformation 2
com.gridsystems.innergrid.kernel.simplemonitor.SimpleMonitorAAService 2
com.gridsystems.innergrid.kernel.startup.KernelInitializer 5
com.gridsystems.innergrid.kernel.startup.KernelLauncher 1
com.gridsystems.innergrid.kernel.startup.KernelLauncher$Sleeper 1
com.gridsystems.innergrid.kernel.startup.KernelStartupChecker 2
com.gridsystems.innergrid.kernel.startup.PluginLogConfigurator 3
com.gridsystems.innergrid.kernel.tools.DOMUtils 1

com.gridsystems.innergrid.kernel.Kernel

Bug Category Details Line
com.gridsystems.innergrid.kernel.Kernel.<static initializer>() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 134
com.gridsystems.innergrid.kernel.Kernel.retrieveKernelVersion() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 414
com.gridsystems.innergrid.kernel.Kernel.aas isn't final and can't be protected from malicious code MALICIOUS_CODE MS_CANNOT_BE_FINAL 111
com.gridsystems.innergrid.kernel.Kernel.manager isn't final and can't be protected from malicious code MALICIOUS_CODE MS_CANNOT_BE_FINAL 106
com.gridsystems.innergrid.kernel.Kernel.registry isn't final and can't be protected from malicious code MALICIOUS_CODE MS_CANNOT_BE_FINAL 101
com.gridsystems.innergrid.kernel.Kernel.timer isn't final and can't be protected from malicious code MALICIOUS_CODE MS_CANNOT_BE_FINAL 116
com.gridsystems.innergrid.kernel.Kernel.kernelVersion should be package protected MALICIOUS_CODE MS_PKGPROTECT 96
com.gridsystems.innergrid.kernel.Kernel.listenerList isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 123

com.gridsystems.innergrid.kernel.Messages

Bug Category Details Line
Naked notify in com.gridsystems.innergrid.kernel.Messages.loadMessages(String) MT_CORRECTNESS NN_NAKED_NOTIFY 213

com.gridsystems.innergrid.kernel.crypto.CryptoService

Bug Category Details Line
com.gridsystems.innergrid.kernel.crypto.CryptoService.readKey(File) invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 243
com.gridsystems.innergrid.kernel.crypto.CryptoService.writeKey(File) invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 265
Inconsistent synchronization of com.gridsystems.innergrid.kernel.crypto.CryptoService.key; locked 66% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 303
Should com.gridsystems.innergrid.kernel.crypto.CryptoService.getKeyFileData() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 188
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.crypto.CryptoService.getInstance() STYLE REC_CATCH_EXCEPTION 111
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.crypto.CryptoService.writeKey(File) STYLE REC_CATCH_EXCEPTION 263
com.gridsystems.innergrid.kernel.crypto.CryptoService.createKey() ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 387
com.gridsystems.innergrid.kernel.crypto.CryptoService.setKeyFileData(byte[]) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 211
com.gridsystems.innergrid.kernel.crypto.CryptoService.writeKey(File) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 255

com.gridsystems.innergrid.kernel.examples.dummy.DummyAAService

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 75
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 80

com.gridsystems.innergrid.kernel.examples.dummy.DummyApiImpl

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 82

com.gridsystems.innergrid.kernel.plugin.AbstractPluginFactory

Bug Category Details Line
com.gridsystems.innergrid.kernel.plugin.AbstractPluginFactory.log isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 35

com.gridsystems.innergrid.kernel.plugin.PluginAdapter

Bug Category Details Line
com.gridsystems.innergrid.kernel.plugin.PluginAdapter.getLicenseFields() may expose internal representation by returning PluginAdapter.licenseFields MALICIOUS_CODE EI_EXPOSE_REP 220
com.gridsystems.innergrid.kernel.plugin.PluginAdapter.setLicenseFields(LicenseField[]) may expose internal representation by storing an externally mutable object into PluginAdapter.licenseFields MALICIOUS_CODE EI_EXPOSE_REP2 229
Exception is caught when Exception is not thrown in new com.gridsystems.innergrid.kernel.plugin.PluginAdapter(boolean) STYLE REC_CATCH_EXCEPTION 144

com.gridsystems.innergrid.kernel.plugin.PluginManager

Bug Category Details Line
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.plugin.PluginManager.logUnresolved(Plugin, PluginMap) STYLE REC_CATCH_EXCEPTION 212
Method com.gridsystems.innergrid.kernel.plugin.PluginManager.logUnresolved(Plugin, PluginMap) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 203
Method com.gridsystems.innergrid.kernel.plugin.PluginManager.supports(Map, PluginMap) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 171

com.gridsystems.innergrid.kernel.plugin.PluginVersion

Bug Category Details Line
com.gridsystems.innergrid.kernel.plugin.PluginVersion defines compareTo(Object) and uses Object.equals() BAD_PRACTICE EQ_COMPARETO_USE_OBJECT_EQUALS 185-199

com.gridsystems.innergrid.kernel.plugin.StaticPluginFactory

Bug Category Details Line
com.gridsystems.innergrid.kernel.plugin.StaticPluginFactory.close(Reader) might ignore java.io.IOException BAD_PRACTICE DE_MIGHT_IGNORE 120

com.gridsystems.innergrid.kernel.server.ApiConfiguration

Bug Category Details Line
Write to static field org.apache.axis.encoding.TypeMappingImpl.dotnet_soapenc_bugfix from instance method com.gridsystems.innergrid.kernel.server.ApiConfiguration.processWSDD(String) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 380
Write to static field org.apache.axis.encoding.TypeMappingImpl.dotnet_soapenc_bugfix from instance method new com.gridsystems.innergrid.kernel.server.ApiConfiguration() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 103
Write to static field org.apache.axis.encoding.TypeMappingImpl.dotnet_soapenc_bugfix from instance method com.gridsystems.innergrid.kernel.server.ApiConfiguration.processWSDD(String) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 399

com.gridsystems.innergrid.kernel.server.KernelConfig

Bug Category Details Line
com.gridsystems.innergrid.kernel.server.KernelConfig.store() ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 436

com.gridsystems.innergrid.kernel.server.OutOfMemoryFilter

Bug Category Details Line
com.gridsystems.innergrid.kernel.server.OutOfMemoryFilter.doFilter(ServletRequest, ServletResponse, FilterChain) invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 192
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.server.OutOfMemoryFilter.doFilter(ServletRequest, ServletResponse, FilterChain) STYLE REC_CATCH_EXCEPTION 187

com.gridsystems.innergrid.kernel.server.RequestFilterEvent

Bug Category Details Line
com.gridsystems.innergrid.kernel.server.RequestFilterEvent.getArguments() may expose internal representation by returning RequestFilterEvent.args MALICIOUS_CODE EI_EXPOSE_REP 78
new com.gridsystems.innergrid.kernel.server.RequestFilterEvent(MessageContext, Method, Object, Object[]) may expose internal representation by storing an externally mutable object into RequestFilterEvent.args MALICIOUS_CODE EI_EXPOSE_REP2 69

com.gridsystems.innergrid.kernel.server.WSSWrapperHandler

Bug Category Details Line
com.gridsystems.innergrid.kernel.server.WSSWrapperHandler.processHeaders(MessageContext, boolean) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 397
com.gridsystems.innergrid.kernel.server.WSSWrapperHandler.getOptions() may expose internal representation by returning WSSWrapperHandler.options MALICIOUS_CODE EI_EXPOSE_REP 188
Nullcheck of ctx at line 294 of value previously dereferenced in com.gridsystems.innergrid.kernel.server.WSSWrapperHandler.handleWSSec(MessageContext, boolean[]) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 277
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.server.WSSWrapperHandler.processHeaders(MessageContext, boolean) STYLE REC_CATCH_EXCEPTION 397
Class com.gridsystems.innergrid.kernel.server.WSSWrapperHandler defines non-transient non-serializable instance field receivers BAD_PRACTICE SE_BAD_FIELD Not available
Method com.gridsystems.innergrid.kernel.server.WSSWrapperHandler.fix(SOAPHeaderElement) directly allocates a specific implementation of xml interfaces STYLE XFB_XML_FACTORY_BYPASS 446

com.gridsystems.innergrid.kernel.services.ApiKernelManagerImpl

Bug Category Details Line
Should com.gridsystems.innergrid.kernel.services.ApiKernelManagerImpl.getMethodNames(String) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 196
Redundant nullcheck of plugins, which is known to be non-null in com.gridsystems.innergrid.kernel.services.ApiKernelManagerImpl.getAllPlugins() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 127
Redundant nullcheck of plugins, which is known to be non-null in com.gridsystems.innergrid.kernel.services.ApiKernelManagerImpl.getPluginNames() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 93
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.services.ApiKernelManagerImpl.getMethodNames(String) STYLE REC_CATCH_EXCEPTION 206

com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl

Bug Category Details Line
com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl.lockShutdown isn't final and can't be protected from malicious code MALICIOUS_CODE MS_CANNOT_BE_FINAL 52

com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl$StopTask

Bug Category Details Line
com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl$StopTask.run() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 123
com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl$StopTask.run() invokes System.exit(...), which shuts down the entire virtual machine BAD_PRACTICE DM_EXIT 127
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl$StopTask.run() STYLE REC_CATCH_EXCEPTION 128
Should com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl$StopTask be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 99-131
Write to static field com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl.lockShutdown from instance method com.gridsystems.innergrid.kernel.services.ApiTomcatManagerImpl$StopTask.run() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 109

com.gridsystems.innergrid.kernel.services.AttachmentCleaner

Bug Category Details Line
com.gridsystems.innergrid.kernel.services.AttachmentCleaner.cleanDir(File) ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 209

com.gridsystems.innergrid.kernel.services.Connector

Bug Category Details Line
com.gridsystems.innergrid.kernel.services.Connector.loadFromFile(File) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 751
com.gridsystems.innergrid.kernel.services.Connector.saveToFile(File, List) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 791
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 861
Comparison of String parameter using == or != in com.gridsystems.innergrid.kernel.services.Connector.minCompression(String, String) BAD_PRACTICE ES_COMPARING_PARAMETER_STRING_WITH_EQ 680
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.services.Connector.toString() STYLE REC_CATCH_EXCEPTION 529

com.gridsystems.innergrid.kernel.services.LicenseZipManager

Bug Category Details Line
com.gridsystems.innergrid.kernel.services.LicenseZipManager.loadLicenses() ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 164
com.gridsystems.innergrid.kernel.services.LicenseZipManager.saveZip(DataHandler) ignores exceptional return value of java.io.File.delete() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 110
com.gridsystems.innergrid.kernel.services.LicenseZipManager.saveZip(DataHandler) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 104

com.gridsystems.innergrid.kernel.services.PluginInfo

Bug Category Details Line
com.gridsystems.innergrid.kernel.services.PluginInfo.getLicenseFields() may expose internal representation by returning PluginInfo.licenseFields MALICIOUS_CODE EI_EXPOSE_REP 189
com.gridsystems.innergrid.kernel.services.PluginInfo.setLicenseFields(LicenseField[]) may expose internal representation by storing an externally mutable object into PluginInfo.licenseFields MALICIOUS_CODE EI_EXPOSE_REP2 200

com.gridsystems.innergrid.kernel.services.ServerInformation

Bug Category Details Line
com.gridsystems.innergrid.kernel.services.ServerInformation.getServerPorts() may expose internal representation by returning ServerInformation.serverPorts MALICIOUS_CODE EI_EXPOSE_REP 60
com.gridsystems.innergrid.kernel.services.ServerInformation.setServerPorts(ServerPort[]) may expose internal representation by storing an externally mutable object into ServerInformation.serverPorts MALICIOUS_CODE EI_EXPOSE_REP2 68

com.gridsystems.innergrid.kernel.simplemonitor.SimpleMonitorAAService

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 76
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 81

com.gridsystems.innergrid.kernel.startup.KernelInitializer

Bug Category Details Line
Incorrect lazy initialization of static field com.gridsystems.innergrid.kernel.Kernel.aas in com.gridsystems.innergrid.kernel.startup.KernelInitializer.setup(ServletContext) MT_CORRECTNESS LI_LAZY_INIT_STATIC 162-164
Incorrect lazy initialization and update of static field com.gridsystems.innergrid.kernel.startup.KernelInitializer.onKernel in com.gridsystems.innergrid.kernel.startup.KernelInitializer.initJmx() MT_CORRECTNESS LI_LAZY_INIT_UPDATE_STATIC 85-87
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.startup.KernelInitializer.initJmx() STYLE REC_CATCH_EXCEPTION 90
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.startup.KernelInitializer.setup(ServletContext) STYLE REC_CATCH_EXCEPTION 153
com.gridsystems.innergrid.kernel.startup.KernelInitializer.initAxis(ServletContext) ignores exceptional return value of java.io.File.setReadOnly() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 291

com.gridsystems.innergrid.kernel.startup.KernelLauncher

Bug Category Details Line
com.gridsystems.innergrid.kernel.startup.KernelLauncher.main(String[]) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 188

com.gridsystems.innergrid.kernel.startup.KernelLauncher$Sleeper

Bug Category Details Line
com.gridsystems.innergrid.kernel.startup.KernelLauncher$Sleeper.run() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 215

com.gridsystems.innergrid.kernel.startup.KernelStartupChecker

Bug Category Details Line
new com.gridsystems.innergrid.kernel.startup.KernelStartupChecker(ServletContext, KernelListener[]) may expose internal representation by storing an externally mutable object into KernelStartupChecker.listenerList MALICIOUS_CODE EI_EXPOSE_REP2 71
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.startup.KernelStartupChecker.run() STYLE REC_CATCH_EXCEPTION 123

com.gridsystems.innergrid.kernel.startup.PluginLogConfigurator

Bug Category Details Line
com.gridsystems.innergrid.kernel.startup.PluginLogConfigurator.mergeInto(Properties, File) might ignore java.net.MalformedURLException BAD_PRACTICE DE_MIGHT_IGNORE 138
Exception is caught when Exception is not thrown in com.gridsystems.innergrid.kernel.startup.PluginLogConfigurator.findResources(String) STYLE REC_CATCH_EXCEPTION 235
com.gridsystems.innergrid.kernel.startup.PluginLogConfigurator.getConfiguration(ServletContext) ignores exceptional return value of java.io.File.mkdirs() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 117

com.gridsystems.innergrid.kernel.tools.DOMUtils

Bug Category Details Line
Incorrect lazy initialization of static field com.gridsystems.innergrid.kernel.tools.DOMUtils.builder in com.gridsystems.innergrid.kernel.tools.DOMUtils.getBuilder() MT_CORRECTNESS LI_LAZY_INIT_STATIC 88-89